Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiclysm: Alchemy Part 3- Technomancer Crafts & Magic weapon worldgen #34727

Merged
merged 23 commits into from Oct 30, 2019
Merged

Magiclysm: Alchemy Part 3- Technomancer Crafts & Magic weapon worldgen #34727

merged 23 commits into from Oct 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 13, 2019

Summary

SUMMARY: Mods "Magiclysm: Technomancer crafts & enchanted weapon worldgen"

Purpose of change

Continues #34205
Adds Technomancer-related crafts, and allows the +1/+2 weapons & some unique new weapons to spawn in the black dragon & demon spider lairs.

Describe the solution

Complete list of changes:

  1. Moved school weapons to appropriate enchanted folder .jsons.
  2. Added:

-Springstaff(extending staff that can be a baton when retracted, based off this design)
-->Works with Silat & Ninjutsu extended, Silat/Krav/Eskrima/Fenching retracted

-M47A1 Techno-Medusa(Technomancer reproduction of the defunct Phillips & Rodgers M47 Medusa, a multi-caliber revolver able to fire technically any centerfire cartridge .357 Magnum or smaller, but is restricted to the original 25 ammo types the gun was marketed for/5 ingame ammo types)
-->Works with Krav Maga

-Gunblade(small pump shotgun mounted on the back of a falcata for chopping action, Final Fantasy fans rejoice)
-->Works with Medieval Swordsmanship &Ninjutsu

-Shotcestus(Sawn-off DB shotgun on top of cestus, inspired by Assassin's Creed's worn guns; STR7 requirement to fire due to not having a stock to absorb recoil)
-->Works with Judo/Aikido's restricted fist weapon list
-->Comes with BRUTAL technique to setup finishing headshot

-Mana laser & dot sights, that use crystallized mana & a small mana crystal respectively instead of a red LED. Laser sight can rotate to fit the rail or underbarrel locations.

-"Silent Winds" suppressor, uses Will-o-Wisp dust for a localized silence spell to enhance wipe media of a solvent trap suppressor.
3. Added book for the shotcestus, mana sights, and suppressor.
4. Added the +1/+2 weapons to new loot itemgroups that spawn in the black dragon & demon spider lairs. Weightings copied from museum_melee, as it had the most complete list of the mundane variants.
5. Added copper infusion bracelet recipe to Soulbinder's Guide & Magitek Illustrated so players aren't stuck having to track down Beginner's Guide to Alchemy.
6. Updated recipe books to use metric strings for volume & weight.
7. Added myself as third Magiclysm author(KorG said I can 🎉)

Describe alternatives you've considered

Adding non-advertised cartridges to the M47A1 such as .32ACP(Ian McCollum demonstrates possibility in the above linked video) or .357 SIG, canceled for having resulting description being huge.
Adding Fencing to the gunblade, canceled for not being nimble enough blade.
Adding rifle caliber gunblade variants

Testing

Spawned in black dragon & demon spider lairs to check mapgen. Debug-learned all recipes to check for correct catergories & recipe requirements of craftables.

@ghost ghost changed the title Alchemy 3- Technomancer Crafts & Magic weapon worldgen Magiclysm: Alchemy Part 3- Technomancer Crafts & Magic weapon worldgen Oct 13, 2019
@ghost ghost mentioned this pull request Oct 13, 2019
11 tasks
@foulman
Copy link
Contributor

foulman commented Oct 14, 2019

If you like I think it's fine to sprinkle around some of them wherever medieval weapons drop, musems, antiques, mansions, etc..

data/mods/Magiclysm/enchanted/enchanted_melee.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/enchanted/enchanted_gunmods.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/enchanted/enchanted_gunmods.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/enchanted/enchanted_gunmods.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/enchanted/enchanted_melee.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/enchanted/enchanted_unarmed.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/enchanted/enchanted_unarmed.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/enchanted/enchanted_unarmed.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/recipe_books.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/recipe_books.json Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added Items / Item Actions / Item Qualities Items and how they work and interact Mods: Magiclysm Anything to do with the Magiclysm mod Melee Melee weapons, tactics, techniques, reach attack Mods Issues related to mods or modding labels Oct 14, 2019
@Tevrian
Copy link

Tevrian commented Oct 24, 2019

Two questions, specifically pertaining the the Gunblade.
1: Why a shotgun?
2: Why a falcata?
Also, less a question and more a note, but in what I suppose is the source material for this rendition of the gunblade, Seifer does use something resembling a fencing stance, and that seems to work for him. In addition, historical gunblades (for there were such things) were usually flintlock pistols built into sabres, if recollection serves, and sabres are valid fencing weapons.

Description spacing
Cannith is reference to DnD's Eberron setting's house for artificers & engineers
@KorGgenT KorGgenT merged commit 0445b8b into CleverRaven:master Oct 30, 2019
@ghost ghost deleted the Alch3 branch October 30, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact Melee Melee weapons, tactics, techniques, reach attack Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants