Handle variable ncurses naming better #34549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Github actions builds have been failing due to being unable to find the curses.h header.
This seems to have been caused by this commit in ncurses https://salsa.debian.org/debian/ncurses/commit/6675cdcba4ba0eeca79f55b661622bf135e70d90
Describe the solution
Upon further investigation, it looks like the real problem is that pkg-config expects to ask for "ncursesw" instead of "ncurses", so we are no longer detecting that pkg-config can find ncurses and as a result falling back to specifying no include directory overrides and specifying that we link against the wrong library name.
Describe alternatives you've considered
The makefile is super crufty at this point and could very much stand to have some of this stuff extracted to little helpers or something, but that's not something I want to tackle right now.
Additional context
See also #34545 for the first attempt at fixing this, I think the current PR is a better solution.