Update Cakes so They Spoil

[TheMurderUnicorn]

Summary

SUMMARY: Balance "Adds Spoilage to Cakes"

Purpose of change

Someone pointed out on discord that cakes never spoil and that ain't right.

Describe the solution

I did some quick research online. Looks like cakes will last around 4-5 days unrefrigerated, although it does vary based on conditions that we can't actually measure in Cataclysm (like adjusting the spoilage timer based on whether it's been cut, how thick the frosting is, etc.) so I called it 4 days and that's that.

For cake 1, the buttercream cake, I set it to a little over two days. Apparently buttercream doesn't do well at room temperature and thus that cake has a lower shelf life. Honestly, the 52 hours I set it to might be a little generous.

Additional context

It may be worth looking into whether the buttercream cake should get the FREEZERBURN flag. Apparently buttercream is a little difficult to keep together when taking it to/from frozen. I don't know if this qualifies as making it 'rotten', but it certainly isn't good for the cake. That's not really what I came to do, though, so I just left it alone.

[KorGgenT]

when you say "last" does that include the fact that the cake is uncovered?and all the other "average" stuff that happens, like general grimyness of the surface it's on

[TheMurderUnicorn]

Well, according to this: https://www.thekitchn.com/expert-advice-how-to-wrap-stor-151924
the icing on cakes acts as a natural barrier to prevent air and moisture from becoming an issue. Air and light and things increase the rate at which oil goes rancid and stuff like that. That's why I referenced cutting them changing the numbers in original PR.

As for general grossness, I actually thought they came in boxes, which is actually not correct, apparently they're just . . . cakes. Mostly you find cakes in bakeries, where they look like they would just be undisturbed in displays or on counters.

Do you think I should further reduce their times? Alternatively, I could assign them a box but I don't know which box would fit a 2 liter cake, I remember having issues finding bags/boxes that actually fit things.

[TheMurderUnicorn]

Upon further thinking and review, I am actually happy with my original numbers.

A cake won't rot or be harmful until several days later. It might not taste so good, but it isn't rotten and still has value as food. Addressing them being in a container doesn't actually solve any problem because it's not guaranteed they will be in a box at all times.

So yeah, I'm going to leave it as is, if ya'll don't want to merge it or whatever, that's okay, or if someone wants to change it later, I trust ya'll know best.