Magic sound effects and AEA_NOISE #34310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[JSON]
Qrox
reviewed
Sep 29, 2019
| @@ -217,6 +218,12 @@ void spell_type::load( JsonObject &jo, const std::string & ) | |||
| mandatory( jo, was_loaded, "name", name ); | |||
| mandatory( jo, was_loaded, "description", description ); | |||
| optional( jo, was_loaded, "message", message, to_translation( "You cast %s!" ) ); | |||
| optional( jo, was_loaded, "sound_description", sound_description, | |||
There was a problem hiding this comment.
You need to update extract_json_strings.py to extract this string for translation.
KorGgenT
force-pushed
the
magic-sound-effects
branch
from
4ce3249 to
6c0c60f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "adds a noise spell effect that only causes noise, and adds AEA_NOISE"Purpose of change
part of the artifact project and #34142
this adds more optional functionality to spell::make_sound, to be able to change any of the inputs to sounds::sound(). this could allow for custom sound effects, both textual and actual sound. See MAGIC.md for documentation on new spell_type members and JSON usage.
Describe the solution
adds a new overload for make_sound() in order to be able to call the "noise" spell effect with a specific loudness. adds enum traits to sounds::sound_t in order to be able to read these enums from strings.
Additionally, I have decided that it's not worth trying to add the item's name into the message you see at this point, so i dropped that part of the effect.