spell level inheritance for fake_spell #34301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "extra_effects now properly inherit their spell level"
Purpose of change
brought to my attention in https://github.com/KorGgenT/Cataclysm-DDA/issues/83, though improperly characterized as AOE only. What happened was fake_spell was always cast at level 0, no matter what.
Describe the solution
did some shuffling around in fake_spell::get_spell() such that its output level is always below the max, above the minimum, and uses the parent spell's level to determine.