Clearing rubble makes creature under it free. #34295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "You are still stuck in rubble even if you clear it with a shovel after getting stuck in it"
Purpose of change
Fixes #33801
Describe the solution
Remove effect
effect_crushed
from any creature that was on the tile with rubble, after this rubble has been cleared.Should affect: player, NPCs and monsters.
On one hand, some message is required like
The %s frees itself from the rubble!
.On the other hand:
map
looks like a bad place for it, no? Still there are messages there, even inmap::furn_set
.monster::move_effects
andCharacter::move_effects
. But I don't want to duplicate it in the map code, and don't know how to use them from there.Describe alternatives you've considered
None. This solution was suggested in #33801.
Additional context
None