Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing rubble makes creature under it free. #34295

Merged
merged 2 commits into from
Sep 28, 2019

Conversation

ipcyborg
Copy link
Contributor

Summary

SUMMARY: Bugfixes "You are still stuck in rubble even if you clear it with a shovel after getting stuck in it"

Purpose of change

Fixes #33801

Describe the solution

Remove effect effect_crushed from any creature that was on the tile with rubble, after this rubble has been cleared.
Should affect: player, NPCs and monsters.

On one hand, some message is required like The %s frees itself from the rubble!.
On the other hand:

  1. Code in map looks like a bad place for it, no? Still there are messages there, even in map::furn_set.
  2. There are messages for it already: in monster::move_effects and Character::move_effects. But I don't want to duplicate it in the map code, and don't know how to use them from there.

Describe alternatives you've considered

None. This solution was suggested in #33801.

Additional context

None

src/map.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. labels Sep 28, 2019
@ZhilkinSerg ZhilkinSerg merged commit 5397a70 into CleverRaven:master Sep 28, 2019
@ipcyborg ipcyborg deleted the fix-33801-map-clear-rubble branch September 28, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You are still stuck in rubble even if you clear it with a shovel after getting stuck in it.
3 participants