Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix horses making engine sounds. #34287

Merged
merged 2 commits into from
Sep 28, 2019
Merged

Fix horses making engine sounds. #34287

merged 2 commits into from
Sep 28, 2019

Conversation

BevapDin
Copy link
Contributor

SUMMARY: Bugfixes "Fix horses making engine sounds."

  • Combine the two arrays into one. The can't be changed independently anyway (adding more messages than sound levels does not have any effect and less messages will cause UB).
  • Make the array static (the strings are only marked for translation, but translation happens when they get actually used).
  • Emit smoke and noise only for combustion engines.

Note: all other engines make no sound at all.

Fixes #32791.

- Combine the two arrays into one. The can't be changed independently anyway (adding more messages than sound levels does not have any effect and less messages will cause UB).
- Make the array static (the strings are only marked for translation, but translation happens when they get actually used).
- Emit smoke and noise only for combustion engines.
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions labels Sep 28, 2019
@ZhilkinSerg ZhilkinSerg merged commit 832c578 into CleverRaven:master Sep 28, 2019
@BevapDin BevapDin deleted the mdz branch September 28, 2019 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horses hum and make other engine noises when attached to a wagon
2 participants