Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a fairly large 2 seat rowboat #34260

Merged
merged 2 commits into from
Sep 27, 2019
Merged

a fairly large 2 seat rowboat #34260

merged 2 commits into from
Sep 27, 2019

Conversation

bobchaos
Copy link
Contributor

Summary

SUMMARY: Content "Adds a fairly large wooden rowboat"

Purpose of change

There's a distinct lack of variety with the new boats, so let's add some!

Describe the solution

Conceptually, this is either an old rowboat, or a survivor-made one. All parts are wood, and no items spawn in it. Will spawn with other boats with high probability.

Describe alternatives you've considered

Bigger boats!

Additional context

I'd like to try and see if I can make it spawn by a basecamp recipe in the future (a dock expansion would have a final "rowboat" recipe that spawns the rowboat using mapgen, ideally repeatable, but I'm not sure the code supports either, I'm new to cata data mods).

Screenshot:
wood_rowboat_double

@curstwist
Copy link
Contributor

curstwist commented Sep 27, 2019

A river based basecamp is a great idea too.

@bobchaos
Copy link
Contributor Author

bobchaos commented Sep 27, 2019

Yeah I was looking into river expansions when I decided to add this rowboat, but it looks like it will be complicated since riverbanks are 8 different tiles instead of a single tile that gets rotated. I don't think I can avoid having 8 recipes, maybe 4 would work tho. I'ma poke at it over the next few days

edit or did you mean a base built on stilts and pontoon? Cuz that would be awesome! (and presumably prohibitively expensive, but gotta keep our survivors busy somehow I suppose)

@curstwist
Copy link
Contributor

curstwist commented Sep 27, 2019

Take a look at lake shore, and the lake buildings, I think that's what you'll want to use. Can look at lighthouse or lake cabin for how its used

Could extend into the water too I imagine.

@bobchaos
Copy link
Contributor Author

json validations seemed to have failed due to executor config, but the travis error is about vehicle_groups.json, which I did edit, but I can't see the error just now :/ I'll get some sleep and look again tomorrow.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions labels Sep 27, 2019
@ZhilkinSerg
Copy link
Contributor

json validations seemed to have failed due to executor config, but the travis error is about vehicle_groups.json, which I did edit, but I can't see the error just now :/ I'll get some sleep and look again tomorrow.

You need to lint updated json files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants