Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for NPC jobs - add data to categorize job roles and duties #34255

Merged
merged 5 commits into from Sep 29, 2019
Merged

Preparation for NPC jobs - add data to categorize job roles and duties #34255

merged 5 commits into from Sep 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 26, 2019

Summary

SUMMARY: Features "Preparation for NPC jobs - add data to categorize job roles and duties"

Purpose of change

This adds support for NPC job categories and what activities may relate to them.

Describe the solution

Added a bunch of npc_job enums, and associated functions to set/get/clear/get name.
added a map of job_id to std::vector<activity_id> to associate what job categories go with what activities.
The thinking being, an NPC assigned to a camp, and given a job will periodically scan for work to do , based on the activities in that list.

Nothing uses this yet - this is preparation and a conscious realization that I need to break my huge PRs up more into smaller, easier to review sections.

Describe alternatives you've considered

I've copied the structure of NPCATT_*
now this may be what people call "cargo-cult programming"? as NPCATT may be the "wrong" thing to copy, so I'll take guidance on a more logical structure for this sort of thing.

Additional context

N/A

@ghost ghost added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership Player Faction Base / Camp All about the player faction base/camp/site labels Sep 26, 2019
@ghost ghost mentioned this pull request Sep 27, 2019
@kevingranade kevingranade merged commit 1b0a472 into CleverRaven:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing NPC / Factions NPCs, AI, Speech, Factions, Ownership Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant