Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lucern hammer spelling #34249

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Fixed lucern hammer spelling #34249

merged 1 commit into from
Sep 27, 2019

Conversation

DanteTorn
Copy link
Contributor

@DanteTorn DanteTorn commented Sep 26, 2019

Summary

SUMMARY: Bugfixes "Fixed lucerne hammer spelling"

Purpose of change

Lucerne hammer is spelled with an E, and even the third Google result will show the CDDA entry when searching "lucern hammer." The ingame name should probably reflect the real-life counterpart is takes after.

Describe the solution

I've renamed the item name, but not the item ID.

Describe alternatives you've considered

I was originally going to change the item ID as well to the proper spelling, but it might mess with peoples' saves or have some unforseen consequences I don't know about, so I left that part be.

Additional context

image


image

@KorGgenT
Copy link
Member

your summaryline is incorrect: SUMMARY: Bugfixes "Fixed lucerne hammer spelling" would be a correct summaryline.

@DanteTorn
Copy link
Contributor Author

your summaryline is incorrect: SUMMARY: Bugfixes "Fixed lucerne hammer spelling" would be a correct summaryline.

Thanks, fixed it.

@I-am-Erk
Copy link
Member

Unfortunately the item ID will probably be stuck like this forever. You could change it and make a second item called 'lucern_hammer' that just copies from 'lucerne_hammer', but there's a high risk for unexpected and annoying little complications. I don't think items support multiple ID aliases.

@DanteTorn
Copy link
Contributor Author

Unfortunately the item ID will probably be stuck like this forever. You could change it and make a second item called 'lucern_hammer' that just copies from 'lucerne_hammer', but there's a high risk for unexpected and annoying little complications. I don't think items support multiple ID aliases.

In my opinion, this isn't too big of a deal. There's plenty of strange IDs for stuff like quarterstaffs having the ID of "q-staff" of all things.

@kevingranade kevingranade merged commit 955583c into CleverRaven:master Sep 27, 2019
@DanteTorn DanteTorn deleted the LucerneHammerFix branch October 2, 2019 19:53
@DanteTorn DanteTorn restored the LucerneHammerFix branch October 2, 2019 19:53
@DanteTorn DanteTorn deleted the LucerneHammerFix branch October 2, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants