Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "hub assembly" to "wheel hub assembly" for easier discovery. #34238

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Rename "hub assembly" to "wheel hub assembly" for easier discovery. #34238

merged 2 commits into from
Sep 26, 2019

Conversation

moxian
Copy link
Contributor

@moxian moxian commented Sep 26, 2019

Summary

SUMMARY: Interface "Rename 'hub assembly' to 'wheel hub assembly' for ease of discoverability"

Fixes #34076

Purpose of change

See #34076 for motivation.
As per Wikipedia, "Wheel hub assembly" and "hub assembly" are both correct terms.

Describe the solution

This is a simple mechanical search-and-replace "hub assembly" -> "wheel hub assembly".
I don't know how exactly translation files work, but the changes make sense at a glance. Reverted changes to translation files.

Describe alternatives you've considered

N/A

Additional context

Tested:
Cataclysm-vcpkg-Release-Win32_2019-09-26_05-53-43

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions labels Sep 26, 2019
@ZhilkinSerg
Copy link
Contributor

Please do not change po-files directly and only change json files. Translation are done through Transifex - see https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/TRANSLATING.md.

@ZhilkinSerg ZhilkinSerg merged commit 384dcdb into CleverRaven:master Sep 26, 2019
@moxian moxian deleted the wheel-hub-assembly branch September 26, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make hub assemblies easier to find in part searches.
2 participants