Heavy mining mod added. Add a mining car. #34229

Ckpyt · 2019-09-25T20:23:13Z

Summary
SUMMARY: Mods "Heavy mining mod added. Add a mining car"

Purpose of change
In my mod, I added a vehicle part, that can crush mineable tiles in 1 tile around it. Plus, added a roadheader with this part, that can be spawned in junkyards, industrial sites or as a workshop vehicle.
Also added a balancer for making balance.

Describe the solution
The possibility of mining with heavy vehicles(because of wight).

Describe alternatives you've considered
The question is: how all underground objects were created? CDDA has only not so effective tools or robots. Any small towns could have subways, laboratory or other objects. So, it means, CDDA should have some more effective heavy mining vehicles from the real world. It is a first step for making it. In future plans, I have mining shields for making subway tunnels, tunnel boring machines and so on...
Additional context

Concept:
Roadheader: https://en.wikipedia.org/wiki/Roadheader,
https://tunnelingonline.com/buying-a-roadheader-heres-what-to-consider/

…ing car too, but it has some bugs with rotation.

Fris0uman · 2019-09-25T20:28:47Z

You need to lint your json files
http://dev.narc.ro/cataclysm/format.html
Also please follow the PR template

KorGgenT · 2019-09-25T20:36:55Z

you also need to astyle your C++

Ckpyt · 2019-09-25T20:41:53Z

you also need to astyle your C++

That I should change?

Is JSON good now?

KorGgenT · 2019-09-25T20:50:44Z

you're going to need to revert the changes you made to the gitignore and the VS project. there's an astyle plugin for VS that'll give you the astyle rules we use on our project; i can give you more details if you need them in a while.

Fris0uman · 2019-09-25T20:51:31Z

See: https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/CODE_STYLE.md for code style guidelines

ZhilkinSerg · 2019-09-25T21:15:20Z

src/vehicle_use.cpp

+                }
+            }
+        }
+        if (crush_target.z != -OVERMAP_LAYERS) { //target chosen


OVERMAP_LAYERS equals to 1 + OVERMAP_DEPTH + OVERMAP_HEIGHT. You probably need to use -OVERMAP_DEPTH here.

Here, I'm checking the value, that never could exist for understanding did I found something or not. As you can understand, any rightful value could not be below -OVERMAP_DEPTH. So, I can use -OVERMAP_DEPTH - 1 or -(OVERMAP_DEPTH + 1) or -(1 + OVERMAP_DEPTH + OVERMAP_HEIGHT).

Right, I started reading code from the bottom, but now see what you mean. I think you better use something else here to avoid confusion - maybe use one of inbounds function that we have?

Yes, it is better. Thanks for help ;-)

ZhilkinSerg · 2019-09-25T21:16:38Z

src/vehicle_use.cpp

@@ -1092,6 +1093,38 @@ void vehicle::play_chimes()
    }
 }

+void vehicle::crash_terrain_around() {
+    const tripoint around[] = { {1, 1, 0}, { 0,1,0 }, {-1, 1, 0}, { 1, 0, 0}, {0, 0, 0}, { -1, 0, 0}, {1, -1, 0}, {0, -1, 0}, {-1, -1, 0} };


We have a collection of neighboring tripoints in

Cataclysm-DDA/src/point.h

Line 352 in ec26a7e

static const std::array<tripoint, 8> eight_horizontal_neighbors = { {

ok. Thanks, I've fixed it.

Could you help me: that is wrong in my code?
Because I have no idea why is test fails.

Failing test is unrelated to your changes it probably caught #33640

and how I can fix it?

ok. I've merged my branch with the newest changes. Maybe, it could help.

ZhilkinSerg · 2019-09-25T21:21:34Z

src/vehicle_use.cpp

@@ -1092,6 +1093,38 @@ void vehicle::play_chimes()
    }
 }

+void vehicle::crash_terrain_around() {


There is void vehicle::transform_terrain() function which already does something like crash_terrain_around does - maybe you can combine it with your code to avoid code duplication?

unfortunately, not. I think about it, but it has a lot of differences.

ZhilkinSerg · 2019-09-25T21:28:03Z

FYI on using Astyle in VS: #24006

Rail-Runner · 2019-09-26T05:38:07Z

Any chance for this to be mainline content? Well, at least the vehicle parts until there's a proper support for tracks.

Ckpyt · 2019-09-26T09:32:27Z

Any chance for this to be mainline content? Well, at least the vehicle parts until there's a proper support for tracks.

The part has a big mass and using this part without tracks - is a really bad idea. Also, wheels cannot live a long time in a mine - its destroyed after 5-10 minutes of working. So, the vehicle should have tracks. Without it - there is no chance to be mainline content ;-(

…to Ckpyt_dev

thethunderhawk · 2019-09-27T16:10:42Z

Tbh I think the player personally running a tunnel boring machine is a bit out of the scope of mainline CDDA. You’re talking about displacing thousands of tons of soil and rock. Even just digging a man-sized tunnel with a pickaxe would realistically take a lot of excavating of material (see The Great Escape), I’ve always just assumed we’re abstracting that by inflating dig times, but moving a whole subway tunnel’s worth of debris would seem to stretch the realism of that far past the limit.

As a mod I love it though. Maybe consider one of these: http://www.sheepletv.com/nuclear-tunnel-boring-machines-switzerland-has-nothing-on-us-2/

Ckpyt · 2019-09-27T23:30:33Z

Tbh I think the player personally running a tunnel boring machine is a bit out of the scope of mainline CDDA. You’re talking about displacing thousands of tons of soil and rock.

It is more about the game mechanic: my mod just destroying anything around the part. So, how much soil, clay or stone - depends on a game engine. Also, it is a good mechanism to mine some ores - they really rare to mine by hands tools.

I’ve always just assumed we’re abstracting that by inflating dig times, but moving a whole subway tunnel’s worth of debris would seem to stretch the realism of that far past the limit.

It will take much more time and low fuel then now. Now, it consumes 60 litres of diesel fuel for 3 hours working. To my mind, it is good for fast-boring, but digging a tunnel should take much more time and not so much fuel. Maybe, it will be nuclear-powered ;-)

As a mod I love it though.

Thanks a lot ;-)

merging all the new changes

Pervios build fails on Android build - there was not enought time for the task.

Ckpyt · 2019-09-28T15:18:32Z

All the tests had passed. Before, Android build has not enough time for building, now - the last one. So, everything is good and passed but not at the same time ;-(

getting latest changes

Aspire2 Student and others added 2 commits September 24, 2019 01:03

heavy mining mod added. Add possonility to mine from a car. Add a min…

efe8cbd

…ing car too, but it has some bugs with rotation.

Final fixings. Everything added and works well.

c3af782

Ckpyt added 2 commits September 26, 2019 08:31

some json format fixings

7eee222

json Lint's fixings

afbe746

KorGgenT added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding labels Sep 25, 2019

c++ astyle

09f4b99

Ckpyt added 2 commits September 26, 2019 08:59

undo version changes

5f89091

undo .gitignore

81490f6

ZhilkinSerg reviewed Sep 25, 2019

View reviewed changes

Ckpyt added 4 commits September 26, 2019 22:58

astyle fixings

8e0b83f

Merge branch 'Ckpyt_dev' of https://github.com/Ckpyt/Cataclysm-DDA in…

f1b0f01

…to Ckpyt_dev

comparison between signed and unsigned integer expressions fix.

326f1f5

astyle fixings2

93fba92

Ckpyt and others added 3 commits September 28, 2019 11:50

Merge pull request #1 from CleverRaven/master

a4d4c56

merging all the new changes

Merge branch 'master' into Ckpyt_dev

9f5f6f6

Merging with last cghanges commit.

5731907

Ckpyt requested a review from ZhilkinSerg September 28, 2019 09:28

just for rebuild.

295808a

Pervios build fails on Android build - there was not enought time for the task.

Merge pull request #2 from CleverRaven/master

0ae8fbd

getting latest changes

weekly-digest bot mentioned this pull request Sep 29, 2019

Weekly Digest (22 September, 2019 - 29 September, 2019) #34319

Closed

ZhilkinSerg self-assigned this Oct 1, 2019

ZhilkinSerg merged commit a8dfd59 into CleverRaven:master Oct 1, 2019

ZhilkinSerg removed their assignment Oct 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Heavy mining mod added. Add a mining car. #34229

Heavy mining mod added. Add a mining car. #34229

Ckpyt commented Sep 25, 2019 •

edited

Loading

Fris0uman commented Sep 25, 2019 •

edited

Loading

KorGgenT commented Sep 25, 2019

Ckpyt commented Sep 25, 2019

KorGgenT commented Sep 25, 2019

Fris0uman commented Sep 25, 2019 •

edited

Loading

ZhilkinSerg Sep 25, 2019

Ckpyt Sep 25, 2019

ZhilkinSerg Sep 25, 2019

Ckpyt Sep 25, 2019

ZhilkinSerg Sep 25, 2019

Ckpyt Sep 25, 2019

Ckpyt Sep 27, 2019

ZhilkinSerg Sep 27, 2019

Ckpyt Sep 27, 2019

Ckpyt Sep 27, 2019

ZhilkinSerg Sep 25, 2019

Ckpyt Sep 25, 2019

ZhilkinSerg commented Sep 25, 2019

Rail-Runner commented Sep 26, 2019

Ckpyt commented Sep 26, 2019

thethunderhawk commented Sep 27, 2019 •

edited

Loading

Ckpyt commented Sep 27, 2019

Ckpyt commented Sep 28, 2019

Heavy mining mod added. Add a mining car. #34229

Heavy mining mod added. Add a mining car. #34229

Conversation

Ckpyt commented Sep 25, 2019 • edited Loading

Fris0uman commented Sep 25, 2019 • edited Loading

KorGgenT commented Sep 25, 2019

Ckpyt commented Sep 25, 2019

KorGgenT commented Sep 25, 2019

Fris0uman commented Sep 25, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZhilkinSerg commented Sep 25, 2019

Rail-Runner commented Sep 26, 2019

Ckpyt commented Sep 26, 2019

thethunderhawk commented Sep 27, 2019 • edited Loading

Ckpyt commented Sep 27, 2019

Ckpyt commented Sep 28, 2019

Ckpyt commented Sep 25, 2019 •

edited

Loading

Fris0uman commented Sep 25, 2019 •

edited

Loading

Fris0uman commented Sep 25, 2019 •

edited

Loading

thethunderhawk commented Sep 27, 2019 •

edited

Loading