Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use named constant for clang-tidy #34224

Merged
merged 1 commit into from
Sep 25, 2019
Merged

use named constant for clang-tidy #34224

merged 1 commit into from
Sep 25, 2019

Conversation

KorGgenT
Copy link
Member

@KorGgenT KorGgenT commented Sep 25, 2019 •
edited
Loading

Summary

SUMMARY: none

Purpose of change

Fixes the shown clang-tidy error:
image

Describe the solution

Describe alternatives you've considered

Additional context

@KorGgenT KorGgenT added <Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Sep 25, 2019
@AMurkin
Copy link
Contributor

AMurkin commented Sep 25, 2019

Alternative is // NOLINT(cata-use-named-point-constants)

@kevingranade kevingranade merged commit 8d08e41 into CleverRaven:master Sep 25, 2019
@weekly-digest weekly-digest bot mentioned this pull request Sep 29, 2019
Closed
@KorGgenT KorGgenT deleted the clang-tidy-happy branch August 13, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KorGgenT @AMurkin @kevingranade