Can't skin skinless #34221
Merged
Can't skin skinless #34221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
Items / Item Actions / Item Qualities
Qrox
reviewed
Sep 25, 2019
| uilist smenu; | ||
| smenu.desc_enabled = true; | ||
| smenu.text = _( "Choose type of butchery:" ); | ||
|
|
||
| smenu.addentry_col( BUTCHER, enough_light, 'B', _( "Quick butchery" ), cut_time( BUTCHER ), | ||
| const std::string cannot_see = colorize( _( "can't see!" ), c_red ); |
There was a problem hiding this comment.
Maybe change it to something like "too dark"? Otherwise players might think that there are some problems with their eyes.
There was a problem hiding this comment.
Huh, so what happens if the player is boomered etc and actually cannot see? Will they be able to start butchering or is this message displayed?
There was a problem hiding this comment.
i didn't check with boomered, but i checked with a blindfold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Skinning action no longer available when corpse has no skin to begin with"Purpose of change
Fixes #28209
and reduces keypresses for butchery when dark.
Describe the solution
Checks the harvest list of the mtype related to the item when butchering, and puts that logic into the UI
Additional context
The text descriptions in the code were very long, so i broke them up a little bit.