When NPC leaves your followers, form appropiate dynamic faction. #34203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm new faction properly
ZhilkinSerg
added
<Bugfix>
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "When NPC leaves your followers, form appropiate dynamic faction."Purpose of change
When NPC leaves your followers, form appropiate dynamic faction.
Describe the solution
Added the code to create new faction when NPC leaves your followers, Improved the add_new_faction() code, as it had an un-necessary call to faction_manager::get() which overrode the name of the faction to blank.
Describe alternatives you've considered
N/A
Additional context
N/A