Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all MShock derived tilesets. #34196

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: Content "Remove all MShock derived tilesets."

Purpose of change

It was brought to my attention that the DeadPeople tileset contains a copy of a tile from the Minecraft HarvestCraft mod.
https://harvestcraftmod.fandom.com/wiki/Epic_Bacon
A copy of this tile is used for the "Jerky" tile.
Upon further research, it turns out this tile is also used in the MShock and Chesthole tilesets.

Describe the solution

Remove all of the affected tilesets and their dependent mods.
Change the default tileset to retrodays.

Additional context

In addition to this particular tile being a license violation, it casts suspicion on the sourcing of the remainder of the tiles, I can't in good conscience include any of these tilesets without them being cleaned up and the provenance of the tiles being established.

@ZhilkinSerg ZhilkinSerg added Mods Issues related to mods or modding SDL: Tiles / Sound Tiles visual interface and sounds. labels Sep 23, 2019
@ZhilkinSerg ZhilkinSerg merged commit 76c0f39 into CleverRaven:master Sep 23, 2019
@CleverRaven CleverRaven deleted a comment from 12347654 Sep 23, 2019
@Firestorm01X2
Copy link
Contributor

Firestorm01X2 commented Sep 23, 2019

A copy of this tile is used for the "Jerky" tile.

So. Instead of blacking out on tile whole tileset gone away. Pretty rushed solution.
And it is huge step back in development.

I heard that Dead People tileset author deleted his sources because of that.

It is really bad.

I agree that license violation, is serious thing but there was no timer. It was better to contact author(s) and ask him (them) directly.

@Inglonias
Copy link
Contributor

Inglonias commented Sep 23, 2019

A copy of this tile is used for the "Jerky" tile.

So. Instead of blacking out on tile whole tileset gone away. Pretty rushed solution.
And it is huge step back in development.

The sad truth is that it could very well be just that one tile, but if it isn't, and the license holders find out, that lands the entire project in a whole heap of trouble. The only responsible thing to do is to take it down. If you're willing and able to prove that the rest of the tileset is fine, do so and it may come back. Unless and until that happens, the risk is simply too high to keep those tilesets in the repo. At best, the license holders would ask us to remove the tilesets. At worst, they'd shut down the repo completely.

I heard that Dead People tileset author deleted his sources because of that.
It is really bad.

That's not exactly something you can blame Kevin for. SDG didn't make that tile, and I personally suspect that their original work is exactly that - original. But the tile in question was found in the original MShock tileset, and AFAIK, the author of that isn't around anymore, so we can't ask them what else they may have used inappropriately. For all I know, it wasn't intentional. They may have just used stuff and didn't know it could cause problems.

The bottom line is that anyone can still use affected tilesets, but they can't be included in this repo without potential trouble, especially now that we know about the problem. I'm not a lawyer, but I can't imagine the consequences of copyright infringement become less severe when you know you're doing it.

I agree that license violation, is serious thing but there was no timer. It was better to contact author(s) and ask him (them) directly.

That can still happen, and when that's done, that's when the tile sets can come back up.

@Firestorm01X2
Copy link
Contributor

Firestorm01X2 commented Sep 23, 2019

That can still happen, and when that's done, that's when the tile sets can come back up.

Now I've really doubt that SDG will work on that. And I can undererstand him.
And since authors of other tilesets gone - there is problem.

@anothersimulacrum
Copy link
Member

SDG'S removal of the source was unrelated

https://discourse.cataclysmdda.org/t/abandoned-32x32-msx-dead-people-tileset/18775/370

@Firestorm01X2
Copy link
Contributor

Firestorm01X2 commented Sep 23, 2019

I have suspicion that this tile was around for a long time.
So next step- removing built versions and stable versions?

@ZhilkinSerg
Copy link
Contributor

I have suspicion that this tile was around for a long time.
So next step- removing built versions and stable versions?

Yes, we are working on that.

@Chezzo
Copy link
Contributor

Chezzo commented Sep 23, 2019

So what do I need to do to get my set back up?

@kevingranade
Copy link
Member Author

I'd traced it back to MShock previously, but after some further digging, it looks like the source is BlockHead tileset, which was obsoleted a looong time ago.

That in turn seems to have gotten it from Raga tileset, which was never in the repository but was published on the forums:
https://discourse.cataclysmdda.org/t/raga-32x32-tileset-wip-85/4401

I would say at a minimum everything pulled in via Raga is suspect, and ideally we'd have a better idea of where everything comes from.

@lispcoc
Copy link
Contributor

lispcoc commented Sep 24, 2019

Why ChestHole16Tileset still exists?

@MikuMiddo
Copy link
Contributor

Through it was a mistake,when it would come back in game again?It is quite a great tileset to us normal player

@anothersimulacrum
Copy link
Member

Through it was a mistake,when it would come back in game again?

When they are "cleaned up and the provenance of the tiles [is] established".

@ZhilkinSerg
Copy link
Contributor

Through it was a mistake,when it would come back in game again?It is quite a great tileset to us normal player

What was a mistake?

@kevingranade
Copy link
Member Author

I think they mean, "a mistake happened including the bad tile(s)"

@terribleperson
Copy link
Contributor

terribleperson commented Sep 25, 2019

Since it's difficult verging on impossible to prove that an artist is the original creator of a tile, but easy to prove that someone is not, what's the official plan? All raga-derived tiles are suspect and no tileset can be included without those tiles being removed or replaced? All BlockHead-derived tiles are suspect? All MShock-derived tiles are suspect? I believe there is art in MShock32 that was originally created for Cataclysm, so I'd hate to see all those tiles have to be excised.

edit: From what you're saying here and on Reddit, it seems like bare minimum any tiles that can be traced back to plants in Raga are probably stolen. If Raga was the work of one person, I'd say the safe assumption is that all the sprites in Raga should be assumed stolen, but the forum post credits different parts of the set to different people, with "vegetables" as one section.

Maybe bare minimum anything that can be traced back to Raga's vegetable tiles edited or unedited should be excised, then go through all the 'parent' tilesets and assuming anyone who has one stolen tile probably has more? Is there somewhere we can communicate identified stolen tiles, their first appearance in a tileset (with contributor), and their original source?

@egomassive
Copy link
Contributor

I come back after 2 years to see how my artwork has fared, and it's just been removed. Sad news, but I'm not surprised. I remember a few tiles that appeared to be photographic in origin. As an artist in this set, is there anything I can provide for provenance?

@Chezzo
Copy link
Contributor

Chezzo commented Sep 27, 2019

I hear you, man. That tileset represents MONTHS of pushing pixels around for me.

I stuck up for you in my emails providing provenance.

I will try and include you in my tileset; if I ever finish. Stripping out everything made by anyone who had anything to do with MShock is quite a lot of work.

@egomassive
Copy link
Contributor

Waldo and Colleen's work should be safe too, but Waldo was not happy about being included in MShock's big merger. I mainly tried to imitate Waldo's style which I feel is significantly different from your style @Chezzo , so don't feel obligated to use my art. I would also trust Xotto's work since he started with high-quality assets based on Waldo's work. As for MShock's personal additions, he said his girlfriend helped him make them and he seems to have personal interest in them (i.e. he resubmitted some to SomeDeadGuy since they had degraded in quality.)

If Raga is the only perpetrator it's still a big problem. I looked through his set, and even if you exclude anything derived from Deon it still amounts to 2 to 3 hundred tainted tiles. Some have been replaced over the years but others have numerous derivatives. It'd be a huge job just to identify and blot out all the offenders in MShockXotto+, not to mention the juggernaut of MSX++DeadPeople. ChestHole sets would be the best recovery option since they are much less reliant on older tile sets.

@EvgenijM86
Copy link
Contributor

EvgenijM86 commented Oct 31, 2019

Tiles are still available in git history. This means that you are still redistributing them with any git clone requests. Doing git revert 14e4410 restores them.

@mryellow
Copy link

mryellow commented Oct 31, 2019

So what you're saying is I need to fork this repo and maintain the old history to ensure the game is playable? Why would someone go out of their way to not only break the current release but all past history.

@EvgenijM86
Copy link
Contributor

I am not asking for anything. I am simply letting you know that this is still the case, because I got the impression that it was important for cata devs to not redistribute someone else assets without their permission. If its not important as long as it is "hidden under the rug" then I can absolutely understand that.

@kevingranade
Copy link
Member Author

kevingranade commented Nov 1, 2019 via email

@tjaska
Copy link

tjaska commented Nov 2, 2019

If the copyright holders were insistent that these files being available from github presented a problem, we could look into expunging them from the project history

Why is this not the default stance for the current build? Remove the offending artwork and leave the rest. I'm scratching my head trying to grasp how is it more reasonable to ask artists responsible for presumably thousands or tile images to prove these are original work instead of acting when someone objects (as, from the quoted part, seems to be the case for historic builds of the game). The whole burden of proof seems to be upside down here.

@kevingranade kevingranade deleted the mshockectomy branch November 3, 2019 02:33
@CleverRaven CleverRaven locked as resolved and limited conversation to collaborators Nov 3, 2019
@kevingranade
Copy link
Member Author

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/what-happened-to-old-tile-set-in-0-e/24498/5

@kevingranade
Copy link
Member Author

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/what-happened-to-old-tile-set-in-0-e/24498/10

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Mods Issues related to mods or modding SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.