Make mapgen code a bit simpler: #34194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also convert it into a class for consistency. And add some preliminary documentation.
Some function take a parameter of that type and modify it via non-const member calls. At least this creates a consistent interface.
Instead of passing forward all the values that the function uses to construct such an object on its own.
The parameters are: - when (`time_point`) - mission (`mission *`) - monster spawn density (`float`) - overmap terrain type (`oter_id`) - map to generate on (`map &`) Those parameters are forwarded to many mapgen function, but are actually rarely used. Moving them into the `mapgendata` class allows simpler function declarations.
It's not needed in any of the header files that used to include it. Those files need at most a forward declaration.
Not needed in the header.
Not needed there.
ZhilkinSerg
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneInstead of forwarding several things to each mapgen related function (e.g. monster density, mission, time point), put them all into the existing
mapgendataclass and only forward a reference to that class. (This reference was forwarded most of the time anyway).