Allow player to use more multi-zone activities #34192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ZhilkinSerg
added
<Enhancement / Feature>
added 4 commits
September 25, 2019 12:05
# This is the 1st commit message: npc vehicle repair compare npc to player to discount current activity agent deduplicate code into common function - and change fetch_activity back to single item a ta time to avoid erasing inside loop # This is the commit message #2: correct time taken check on vehicle_activity(), more places to check for NPC revert to avoid inf.loops
compare npc to player to discount current activity agent deduplicate code into common function - and change fetch_activity back to single item a ta time to avoid erasing inside loop correct time taken check on vehicle_activity(), more places to check for NPC revert to avoid inf.loops remove comment
added handlng for avatar potentially doing this activity too allow player to use more zone activities neaten up with common function to unify backlog resuming typo
|
Rebased to latest master. now the dependent PR is merged , removign WIP. |
ghost
changed the title
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Allow player to use more multi-zone activities - chopping, deconstructing etc"Purpose of change
Fixes #33250
( fixes that bug due to "improving" the logic of how players and NPCs resume activity backlog or multi-type activities only )
fixed two bugs that seemed as yet unreported.
Tilling/churning soil took no moves, so zone farming was done instantly.
Also chopping logs did not work as it never recognised that the player/npc had the required tool quality.
The main thrust of this however, is that now the player can make use of the new multi-zone activitis that the NPCS use.
Player can now deconstruct/repair a vehicle, chop trees, chop logs into planks, and butcher multiple corpses, with the player automaticlly fetching the right tools for the job if required ( if they are in a loot zone ) , and tidying up afterwards by putting all products of the activity back into an unsorted loot zone.
Less keypresses overall as it just continues with the activity automatically. - Only do this if you really want ALL vehicle parts removed, or ALL trees chopped down, or ALL logs chopped into planks etc.
( that is ALL of the things contained in the zone you specified for the work )
Describe the solution
Added the options to the Shift+O menu, and tweaked the activity loops to allow the player to use them.
Describe alternatives you've considered
N/A
Additional context
N/A