Add position marker to some format strings #34183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: I18N "Add position marker to some format strings"
Purpose of change
There is the need to reorder format parameters in some of the game's strings during translation, but it's currently impossible to do so on Transifex. While the parameters can be reordered, the resulting translation does not have proper position marker added.
Describe the solution
I searched the game's codebase using regex to find strings containing phrases in the form
<format specifier> <preposition> <word> <format specifier>
, where the two format specifier usually need to be swapped during translation (at least in Chinese), and changed the strings I deemed necessary.Describe alternatives you've considered
I have filed a report to Transifex about the problem, but before they eventually fix it this will do for now.