Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add position marker to some format strings #34183

Merged
merged 4 commits into from
Sep 23, 2019

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Sep 22, 2019

Summary

SUMMARY: I18N "Add position marker to some format strings"

Purpose of change

There is the need to reorder format parameters in some of the game's strings during translation, but it's currently impossible to do so on Transifex. While the parameters can be reordered, the resulting translation does not have proper position marker added.

Describe the solution

I searched the game's codebase using regex to find strings containing phrases in the form <format specifier> <preposition> <word> <format specifier>, where the two format specifier usually need to be swapped during translation (at least in Chinese), and changed the strings I deemed necessary.

Describe alternatives you've considered

I have filed a report to Transifex about the problem, but before they eventually fix it this will do for now.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Translation I18n labels Sep 22, 2019
src/item.cpp Show resolved Hide resolved
src/iuse_actor.cpp Show resolved Hide resolved
@Qrox Qrox marked this pull request as ready for review September 23, 2019 14:55
@ZhilkinSerg ZhilkinSerg merged commit fe55636 into CleverRaven:master Sep 23, 2019
@cainiaowu
Copy link
Contributor

May have fixed #17787 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants