Fix crash in vehicle display window #34175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m does not have the wheel item slot.
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: NoneFixes #34154.
The code in
veh_interact::display_detailschecks for the part having the "WHEEL" flag and (if it has the flag) displays the wheel date. That data is taken from theislot_wheelof the base item of the part. The code blindly assumes that all vehicle parts with the "WHEEL" flag will have base items with that item slot being set.The new vehicle part "cart_handle" (added by #33901) has the flag, but the base item is "pipe", which does not have wheel item slot. So it crashes when that vehicle part is displayed.
I added a check in the loading code for this case.
I remove the wheel property from the mentioned vehicle part. Note that the "Grocery Cart" (which uses that part) already has another wheel.