Translate stat name outside enum_to_string #34172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
jbytheway
reviewed
Sep 22, 2019
| std::string get_stat_name( Character::stat Stat ) | ||
| { | ||
| switch( Stat ) { | ||
| // *INDENT-OFF* |
There was a problem hiding this comment.
It's the end of the file, so not a big deal, but you forgot the INDENT-ON.
There was a problem hiding this comment.
So many mistake today U_U
There was a problem hiding this comment.
Oh yeah but I put it back in #34177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Adresse @jbytheway comment :
Describe the solution
Describe alternatives you've considered
Additional context