fix mutations overriding spell level #34166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix mutation-learned spells overriding spell level upon load"
Purpose of change
Brought to my attention here:
chaosvolt/cdda-arcana-mod#82
Spells learned from a mutation were loaded in before the spellbook, because of on_mutation_gain adding the spell before the spellbook loaded in. Due to the spellbook being a map and the load spell using emplace(), the xp saved did not overwrite the original spell given by the mutation.
Describe the solution
Check if the spell is already known when loading the spell, and overwrite the xp if known. adds a new set_exp() function to spell to accomplish this
Additional context