Enchantment values - REGEN_MANA and MAX_MANA #34158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[JSON]
KorGgenT
force-pushed
the
enchantment-values
branch
2 times, most recently
from
86c2a30 to
b45659e
Compare
KorGgenT
force-pushed
the
enchantment-values
branch
from
bc30209 to
a5aae26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Adds REGEN_MANA and MAX_MANA to available enchantment values"Purpose of change
part of #33837 and requires #34145 in order to be merged
Describe the solution
adds in the calculation using the enchantment cache when max_mana is retrieved, and when the amount of mana that regens is calculated.
Additional context
Added in lesser staff of the magi and wizard hat to demonstrate its use.