Tacoma Commune: make the ranch camp map unrotatable #34100
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses CleverRaven#33525 A fair bit of the Tacoma Commune missions still use hard coded C++ functions to update the map, and those functions do not understand map rotation at all. Completing those missions will cause all kinds of weird errors as NPCs teleport around the map and new construction is built into old construction. Make the ranch camp maps unable to rotate until I have time to go through and move the remaining Tacoma Commune missions into JSON.
mlangsdorf
added
<Bugfix>
misterprimus
pushed a commit
to misterprimus/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2019
Addresses CleverRaven#33525 A fair bit of the Tacoma Commune missions still use hard coded C++ functions to update the map, and those functions do not understand map rotation at all. Completing those missions will cause all kinds of weird errors as NPCs teleport around the map and new construction is built into old construction. Make the ranch camp maps unable to rotate until I have time to go through and move the remaining Tacoma Commune missions into JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Tacoma Commune: make the ranch camp map unrotatable"Purpose of change
Addresses #33525
A fair bit of the Tacoma Commune missions still use hard coded C++ functions to update the map, and those functions do not understand map rotation at all. Completing those missions will cause all
kinds of weird errors as NPCs teleport around the map and new construction is built into old construction.
Make the ranch camp maps unable to rotate until I have time to go through and move the remaining Tacoma Commune missions into JSON.
Describe the solution
Set
"rotation": falsefor the"ranch_camp"overmap special.Describe alternatives you've considered
Moving all the remaining hardcoded mission starts to JSON would be preferable, but will also take several days of effort and I'd like to have a fix now.
I could try teaching all of the hardcoded mission start functions about rotation, but that would also take several days.