Mainline jsonified fema camp from the Mapgen Demo mod #34081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
<Enhancement / Feature>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Mainline jsonified fema camp from the Mapgen Demo mod."Purpose of change
Mainline jsonified fema camp from the Mapgen Demo mod.
Describe the solution
Moved overmap terrain, overmap special, pallette from the mod to mainline.
Also removed some unused symbols from pallette.
Also decreased chance to spawn from 1..5 to 0..5 for both versions of FEMA Camp. I think at least one guaranteed spawn of the camp on the overmap is too much.
Also fixed road connection for the camp.
I hesitated to fully replace hardcoded version with this jsonified version as they are way too different. So for now there are two differing versions of the camp - jsonified one and hardcoded one. We can always jsonify hardcoded version later.