Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed money-related perks and millionaire profession #33966

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

l29ah
Copy link
Contributor

@l29ah l29ah commented Sep 11, 2019

Summary

SUMMARY: Content "Removed money-related perks and millionaire profession"

Purpose of change

fixes #32258

Describe the solution

Describe alternatives you've considered

Additional context

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Bugfix> This is a fix for a bug (or closes open issue) labels Sep 11, 2019
@ghost
Copy link

ghost commented Sep 11, 2019

I think some stuff has to be moved to the obselete files (not sure how that works though) so that existing characters with the mutations/profession work properly.

@l29ah
Copy link
Contributor Author

l29ah commented Sep 11, 2019

I think they just vanish with a warning. The profession resets to Evacuee AFAIR.

@Night-Pryanik
Copy link
Contributor

@l29ah please do test this thoroughly so we could be sure we don't get new crashes related to this.

@Rail-Runner
Copy link
Contributor

By the way, listed issue only mentions that the traits have to be removed. I think the profession could stay, but the associated trait would have to be removed from it; having lots of expensive but mostly useless starting items still gets the idea across.

@nexusmrsep
Copy link
Contributor

Any chance of moving them to Crazy Cataclysm Mod?

@Zireael07
Copy link
Contributor

I don't think they fit the crazy cata, but maybe their own mod?

@kevingranade
Copy link
Member

Previously millionaire characters will load, but with a bunch of warnings.
That's not the end of the world, but we should clean this kind of thing up when we know about it.

@kevingranade kevingranade merged commit 5e3c369 into CleverRaven:master Sep 25, 2019
@ZhilkinSerg
Copy link
Contributor

Traits are obsoleted in #34239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Millionaire trait is too costly
7 participants