[CR] [WIP] Optimize generic activities using stages

[ipcyborg]

Summary

SUMMARY: Infrastructure "Optimize generic activities using stages"

Purpose of change

Avoid the possible coordinates looping in generic activities by using stages.
Optimize activity performance.

Describe the solution

Activity stages (stored in activity.index)

1. Initial stage: determine and remember all possible location for this activity.
2. Think stage: think about what to do first: choose a source location to move.
3. Move stage: go to the chosen location.
4. Do stage: do specific activity there, then think what to do next (go to 2).

The location coordinates are processed only once to avoid loops.
Probably it can also be done using some kind of coordinate markings: skipping and then returning to the skipped coordinate?

Not finished yet.

Describe alternatives you've considered

Leave as it is.

Additional context

Changes were rebased from PR #33710, excluding activity_on_turn_move_loot changes (will be done in separate PR).

[ipcyborg]

Still can't make it work.
The main issue is moving stage: now it is done using set_destination.
I may be incorrect, but I see that moving behaves differently for Player and for NPC:

• Player moves using simulated key-presses (see get_next_auto_move_direction).
• NPC moves using get_auto_move_route.

Moving can be done only outside of the activity. See game::process_activity:

while( u.moves > 0 && u.activity ) {
        u.activity.do_turn( u );
    }

So if the current activity has not spend all moving points (moves) -> infinite loop.
And if it has -> no moving points for the actual moving (later, in handle_action).

So for now I don't know how to include moving into the activity stages. And moving outside of the activity (while leaving player activity set to null) leads to some strange behavior on resuming activity from backlog. May be I'm just using the backlog incorrectly and it is not meant to process sub-activities and resume the main activity again.

For now I see one solution: unify moving process (for Player and NPC) and make it a separate activity. Then fix the backlog resuming process.

Any advice?

[ghost]

Would recommend you come to the developer discord to talk about this in more detail, if this is possible for you.

Its tricky to understand what the problem is, and what you are aiming to do.

https://discord.gg/jFEc7Yp

[ipcyborg]

Closed based on the discord discussion results:
It was recommend to keep the structure of the generic activity function, while try to find a way to neaten up the logic and the code.

Separate PR is required.