Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new menu for armor sorting #33799

Closed
wants to merge 13 commits into from
Closed

Conversation

akozhevn
Copy link
Contributor

@akozhevn akozhevn commented Sep 4, 2019

Summary

SUMMARY: Interface "Reorganizing armor sorting menu"

Purpose of change

Current menu is haphazard with similar (and duplicate) data spread over 4 sections

Describe the solution

Move everything into 1 list, so it's easier to read.
Add acid and fire protection.
Add aggregate info for body parts.
Encumberance penalties are now displayed here.
Changed shortcuts to match the rest of the game (u->T, e->W). And added 'd'rop.
Help page is now readable =)

Describe alternatives you've considered

Might be good idea to show formulas for calculating penalties and aggregate data.
I would also propose to redirect 'T'ake off menu here, since it's easier to search than in unsorted list

Additional context

version 1 (short hand notation):
armor_sort

version 2 (cut off):
armor_sort2

version 3 (full names):
armor_sort3l

version 3 (full names):
armor_sort3s

get_encumbrance_description is now part of player.h
@snipercup
Copy link
Contributor

I like the idea. would work nicely on my pc but how will it look on mobile? do we get a scrollbar like with the skills list or will it be multiple pages like advanced inventory?

@Leland
Copy link
Contributor

Leland commented Sep 4, 2019

Hm, not sure that those extremely abbreviated column names will work well once translated.

(Also a little skeptical of the readability of "strge" and "wrm")

src/armor_layers.cpp Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Info / User Interface Game - player communication, menus, etc. labels Sep 4, 2019
adding scrollbar (instead of <more>)
travis fixes
@akozhevn
Copy link
Contributor Author

akozhevn commented Sep 4, 2019

@snipercup there's a scrollbar, I added small res screenshot

@akozhevn
Copy link
Contributor Author

akozhevn commented Sep 4, 2019

@Qrox I fixed static translations and added printing cut off like this
return ( _( name ) ).substr( 0, cut_off );
it should keep the alignment and work with translations too.

still plenty of space to fit them in the screen.

There's not that much space in small res (see new screenshot), definitely not enough to print full names of every column.

I suggest calculating the column width according to the length of the translated text

Spacing matters for displaying data - if data size is same and columns sizes are different it'll be harder to read. And that's basically the thing we are trying to optimize here. =)

src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/player_display.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
src/armor_layers.cpp Outdated Show resolved Hide resolved
@akozhevn
Copy link
Contributor Author

akozhevn commented Sep 5, 2019

@BevapDin I think I got everything

@akozhevn
Copy link
Contributor Author

akozhevn commented Sep 5, 2019

@Qrox Full names and 2 tabs now. Actually isn't as bad bad as I thought it would be.

src/armor_layers.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg self-assigned this Sep 19, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Oct 13, 2019
@ZhilkinSerg ZhilkinSerg added the stale Closed for lack of activity, but still valid. label Apr 30, 2020
@ZhilkinSerg
Copy link
Contributor

Feel free to reopen if you want working on it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants