-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new menu for armor sorting #33799
new menu for armor sorting #33799
Conversation
get_encumbrance_description is now part of player.h
I like the idea. would work nicely on my pc but how will it look on mobile? do we get a scrollbar like with the skills list or will it be multiple pages like advanced inventory? |
Hm, not sure that those extremely abbreviated column names will work well once translated. (Also a little skeptical of the readability of "strge" and "wrm") |
adding scrollbar (instead of <more>) travis fixes
@snipercup there's a scrollbar, I added small res screenshot |
@Qrox I fixed static translations and added printing cut off like this
There's not that much space in small res (see new screenshot), definitely not enough to print full names of every column.
Spacing matters for displaying data - if data size is same and columns sizes are different it'll be harder to read. And that's basically the thing we are trying to optimize here. =) |
BevapDin code fixes
@BevapDin I think I got everything |
@Qrox Full names and 2 tabs now. Actually isn't as bad bad as I thought it would be. |
# Conflicts: # src/armor_layers.cpp
fixing issues when taking clothes off npc adding waterproof condition
Feel free to reopen if you want working on it again. |
Summary
SUMMARY: Interface "Reorganizing armor sorting menu"
Purpose of change
Current menu is haphazard with similar (and duplicate) data spread over 4 sections
Describe the solution
Move everything into 1 list, so it's easier to read.
Add acid and fire protection.
Add aggregate info for body parts.
Encumberance penalties are now displayed here.
Changed shortcuts to match the rest of the game (u->T, e->W). And added 'd'rop.
Help page is now readable =)
Describe alternatives you've considered
Might be good idea to show formulas for calculating penalties and aggregate data.
I would also propose to redirect 'T'ake off menu here, since it's easier to search than in unsorted list
Additional context
version 1 (short hand notation):
version 2 (cut off):
version 3 (full names):
version 3 (full names):