Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up snippets.json #33501

Merged
merged 3 commits into from
Aug 25, 2019
Merged

Conversation

Kanexan
Copy link
Contributor

@Kanexan Kanexan commented Aug 24, 2019

Summary

SUMMARY: Content "Cleans up and updates snippets.json"

Purpose of change

snippets.json was heavily out-of-date with regards to its lore, and many of the survivor notes were plainly either jokes about game mechanics, or were entirely impossible to have written a note in the situation described.

Describe the solution

I've removed the newspaper references to Chinese invasion, replacing them with New Lore-compliant riots and events. The fliers referring to CBMs and lore that no longer exist in-game have been removed or re-written. Most of the survivor notes are unchanged, and it still has a somewhat lighter and more referential/meta aspect than the rest of the game, but the ones which were blatantly impossible to write at all, relied on references to outdated lore (such as the "Green Fever") or were specifically dealing with the peculiarities of in-game mechanics were removed or re-written.

Describe alternatives you've considered

Leaving the file as is, or completely re-writing and purging the survivor notes to be totally non-humorous and non-referential to outside materials.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Translation I18n labels Aug 24, 2019
@kevingranade kevingranade merged commit 8ea2938 into CleverRaven:master Aug 25, 2019
@Kanexan Kanexan deleted the Snippets-Rework branch August 25, 2019 07:18
@Night-Pryanik Night-Pryanik mentioned this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants