Show needs in the comestible inventory windows

[pierredavidbelanger]

Summary

SUMMARY: Features "Show needs in the comestible inventory windows"

Purpose of change

Fixes #33393 - Show hunger/thirst in eat menu

Describe the solution

I simply used the inventory_selector hint line to display a needs bar (using the same stats as the right panels)

Additional context

I could not refrain from refactoring the Creature::get_pain_description() to returns a std::pair<std::string, nc_color> instead of a plain std::string, to mimic what already exist for get_hunger_description and get_thirst_description.

This means I had to touch to creature.h/cpp obviously, but also player.h/cpp to override the function and provide additional insights on the perceived pain, and also panels.cpp to use my new function instead of its own static one.

The Eat window now looks like this:

[jbytheway]

Two minor points:

It might be cleaner to use the colorize function here rather than writing the tags manually in the format string. Then you don't need to bother with get_all_colors.

Also, it might be worth translating this format string just in case another language wants things formatted differently.

[pierredavidbelanger]

@jbytheway oh, nice, I did not see this colorize function, I will make this change, this will make the code cleaner.

Also, about:

translating this format string just in case another language wants things formatted differently

Nothing do do here, it should already be translated since I am using the _( std::string ) function, just like its done in the panels, and also get_hunger_description , get_thirst_description and get_pain_description returns already translated strings.

But, maybe you are suggesting to use a big parametrized string, all in one for the 3 needs ?

[pierredavidbelanger]

Should I push in this already merged PR though or open a new one for this ?