-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset mount moves on dismount #33461
Conversation
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/horse-went-poof/21132/4 |
It might be worth giving the mount a few free moves to use when you're forcibly dismounted. When dismounting voluntarily, a horse should (hopefully) stand there while you do it, but when a brute knocks you flying out of the saddle it would probably look less goofy if the horse were to jump away in the process, rather than just stand there with a surprised look on his face. |
It will get its moves as normal as soon as your dismounted. it will be able to react just as quickly as the player does. And infact often its the horse that is hulk smashed and yeeted long distance, which prompts the forced dismount, so they would react in the same way as the player would then aswell, or any other monster smashed by a hulk |
I'm aware, it just seems like the mount, who is theoretically able to move on his own and only held back by the riding code, should react as it happens instead of after you land. Which I think is not entirely feasible, but might be approximated by giving him some extra moves to count for what he did as you were dislodged. |
The current status of this is that the mount's moves when the player mounts them is preserved through the riding process, so when the player is dismounted, the mount is most likely going to have a non-zero number of moves. |
* stop regeneration of moves instead of resetting on dismount
Summary
SUMMARY: Bugfixes "Reset mount moves on dismount"
Purpose of change
Fixes #32463
Describe the solution
Horses - all mounts, stored up their moves while you are riding them, and never used them.
So it was quite possible for them to have 100,000 moves + after a while.
Then when you dismounted, they used all of them at once.
This resulted in lag, sound /message spam, and often,t he horse zooming off into the distance.
Describe alternatives you've considered
N/A
Additional context
N/A