Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mana inefficiency mutations giving mana #33454

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

Highmongrel
Copy link
Contributor

@Highmongrel Highmongrel commented Aug 22, 2019

Summary

SUMMARY: Bugfixes "Makes mana inefficiency negative"

Purpose of change

Currently the mana inefficiency line of mutations adds to your mana cap instead of subtracting from it.

Describe the solution

Add a - sign on the mutations

Describe alternatives you've considered

Leaving a negative mutation with purely positive effect

Additional context

Mutated mana inefficiency with debug and my mana cap went up. Did a small test and it was quick to change

@Highmongrel Highmongrel changed the title fix mana inefficiency fix mana inefficiency mutations Aug 22, 2019
@Highmongrel Highmongrel changed the title fix mana inefficiency mutations fix mana inefficiency mutations giving mana Aug 22, 2019
@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [JSON] Changes (can be) made in JSON labels Aug 22, 2019
@ZhilkinSerg ZhilkinSerg requested a review from KorGgenT August 22, 2019 12:02
@KorGgenT KorGgenT self-assigned this Aug 22, 2019
@KorGgenT KorGgenT merged commit 2d04960 into CleverRaven:master Aug 24, 2019
@Highmongrel Highmongrel deleted the mana-inefficiency-fix branch September 8, 2019 02:33
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants