Fixed "Wielding MBR vest with magazines allow to duplicate magazines #33189" #33422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Wielding MBR vest with magazines allow to duplicate magazines #33189"Purpose of change
Fixes #33189
Describe the solution
The code in
pick_one_upmakes a copy of original item to revert the changes in case of cancellation.But at least two places there require the original item reference, not a copy:
Fixed by using original item reference there.
Added comments to specify the usage of original item.
Describe alternatives you've considered
There could be more places that require original item instead of a copy.
Tried to use different logic: do not make a copy and use original item in
pick_one_up.Looks like better but complicated solution.
Additional context
None