Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc to use metric units in string format #33386

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

Fris0uman
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Update JSON_INFO.md to use metric units in string format as suggested in #33367

Describe the solution

Describe alternatives you've considered

Additional context

@ampersand55
Copy link
Contributor

You can add that max_pet_vol, min_pet_vol and integral_volume also use metric units in string format.

Copy link
Member

@KorGgenT KorGgenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some consistency things, since we want a space in the volume strings.

doc/JSON_INFO.md Outdated Show resolved Hide resolved
doc/JSON_INFO.md Outdated Show resolved Hide resolved
doc/JSON_INFO.md Outdated Show resolved Hide resolved
doc/JSON_INFO.md Outdated Show resolved Hide resolved
doc/JSON_INFO.md Outdated Show resolved Hide resolved
doc/JSON_INFO.md Outdated Show resolved Hide resolved
doc/JSON_INFO.md Outdated Show resolved Hide resolved
doc/JSON_INFO.md Outdated Show resolved Hide resolved
doc/JSON_INFO.md Outdated Show resolved Hide resolved
@KorGgenT KorGgenT added the <Documentation> Design documents, internal info, guides and help. label Aug 20, 2019
@KorGgenT KorGgenT merged commit 51f45ee into CleverRaven:master Aug 20, 2019
@Fris0uman Fris0uman deleted the doc_volume branch August 20, 2019 18:03
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* Update doc to use metric units in string format

* more

* Apply suggestions from code review

Co-Authored-By: Curtis Merrill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Documentation> Design documents, internal info, guides and help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants