Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up homemade mags and guns #33376

Merged
merged 13 commits into from
Aug 27, 2019
Merged

Conversation

tenmillimaster
Copy link
Member

@tenmillimaster tenmillimaster commented Aug 20, 2019

Summary

SUMMARY: Balance "handmade mags and clips require handfitting."

Purpose of change

Previously, a survivor could manufacture STANAG pattern magazines, or magazines suitable for Sten guns, etc with no references to work with, and they'd simply magically work.

The descriptions for the Luty magazines were often just plain incorrect.

The stripper clips used nonsensical starting materials (steel chunks).

The 30 round .22LR magazine was too long and thus requiring a curved magazine, which is pretty beyond a survivor's ability to craft. (It was a single stack magazine, so it'd be quite long.

The .38 Special SMG had the audacity to exist. Rimmed automatics don't typically work well.

Describe the solution

All magazines would require a firearm reference, and a single round of ammunition/casing to work off of, to cycle until they actually work.

All clips would require a casing to work with (of the correct case head type, so derivatives are ok) to create working stripper clips.

The Garand en-bloc is a bit of a special case, in that it needs to function with the garand's lifter and receiver internals, so it got treated as a magazine.

The .22LR magazine was shortened to the largest straight single stack magazine I could find.

All the clips now use small sheet metal.

The .38 Special SMG and magazine was migrated to .22lr.

Describe alternatives you've considered

Wholesale deleting the makeshift magazines.

Additional context

Neither the small nor the large gunsmithing kits would really contain tools appropriate for making these items; what's needed is some sort of sheet metal working equipment. Blowtorches would be appropriate as well to spring temper feed lips/stripper clips.

Steel chunks aren't appropriate; (small) metal sheets are more appropriate as starting material.

The AUG and G36 have purposefully been omitted from the STANAG recipe, as these do not actually use stanags.

The briefcase SMG has been omitted from the recipes, as in my opinion this item should get replaced with a more realistic MP5 or MAC-10 based briefcase gun.

The .38 Special magazine and SMG are both simply ridiculous- rimmed cartridges are notoriously difficult to get working in auto-loaders.

@tenmillimaster tenmillimaster added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. labels Aug 20, 2019
@ghost
Copy link

ghost commented Aug 20, 2019

So this is the true purpose for the loose casings I find in the woods! 😛

data/json/recipes/weapon/magazines.json Outdated Show resolved Hide resolved
data/json/recipes/weapon/magazines.json Outdated Show resolved Hide resolved
data/json/recipes/weapon/magazines.json Outdated Show resolved Hide resolved
data/json/recipes/weapon/magazines.json Outdated Show resolved Hide resolved
data/json/recipes/weapon/magazines.json Outdated Show resolved Hide resolved
@tenmillimaster
Copy link
Member Author

I've updated the requirements for the magazines; now they require ammunition AND the gun in question.

@tenmillimaster tenmillimaster changed the title Clips and magazines require hand fitting Clean up Luty mags and SMG's Aug 20, 2019
@tenmillimaster tenmillimaster changed the title Clean up Luty mags and SMG's Clean up homemade mags and guns Aug 20, 2019
@tenmillimaster
Copy link
Member Author

Why are the luty's even here? There's not recipes for them yet. I see the comment on them about tools needed- is this a cart before the horse situation?

@ymber
Copy link
Member

ymber commented Aug 20, 2019

Luty pattern SMGs were added assuming the tools to manufacture them would get implemented at a later date. They're appropriate content, we just need to add more items around them.

data/json/items/magazine/40.json Show resolved Hide resolved
data/json/recipes/weapon/magazines.json Outdated Show resolved Hide resolved
data/json/recipes/weapon/magazines.json Outdated Show resolved Hide resolved
@Rail-Runner
Copy link
Contributor

Rail-Runner commented Aug 20, 2019

Why wouldn't .22 LR SMG work?

UPD: Nevermind, figured it out. Seems like it has kind of a rim too.

misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* hand fit mags
* hk->H&K
* casehead reqs
* mag desc update
* sheet strippers
* delete .38 luty
* axe 22, nerf 40, 762 and 762 recipes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants