Fix picking up liquid water bug #33357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As above.
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix picking up liquid water bug"
Purpose of change
Fixes part of #33354-You can pick up water even if it's not frozen
Describe the solution
Add "made_of_from_type(LIQUID)" judgment back in src/pickup.cpp (notice that the former commit #32763 deleted this and thus failed to change the got_water value.)
Describe alternatives you've considered
Maybe there should be a "is_liquid" attribute or function for the item class?
Additional context
This pr only fix part of the issue. The "hauling water" bug still exists