fix frozen acid drops #33350
Merged
fix frozen acid drops #33350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested it again and it looks like it's still possible to get a crash if you drink the acid, take damage, and interrupt the deconstruction. But at least the handling of the acid as a liquid is fixed. |
ZhilkinSerg
added
<Bugfix>
|
Not sure what that error means: |
|
Not your problem. Just need someone to restart it and try again. |
misterprimus
added a commit
to misterprimus/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixed acid recovery from car battery"Purpose of change
Make it possible to recover acid from car battery.Describe the solution
Recovery of battery acid from car battery only works when the acid is thawed, as it is liquid and you get asked the option of what to do with that liquid when it comes into your possession. This check is not performed when the acid is frozen, which is fine, except acid has a drop action which is triggered, destroying the item and creating puddles of damaging acid fields.Additional context
The code is very confusing, but it looks like this works at least with preliminary testing. Note there is still the bug of frozen acid on the ground NOT thawing and converting to an acid field due to ambient heat - this is only checked when the player tries to pick it up. But I'm pretty sure my changes didn't cause that and it can be fixed in a different PR.