Fix bug where player could not create woodchip floors #33335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered an issue where I could not create a woodchip floor, in an empty shallow pit. I removed the precondition that required it to be empty, and now I can create woodchip floors just fine. I looked at the definition for the empty precondition and it needs the square to be flat and have no furniture, which I'm unsure a shallow pit would count as. I think the spirit of the empty precondition was that there should be no items but it also precluded shallow pits, perhaps there should be another check? Also it seems quite possible this bug applies in other cases in this file, I haven't investigated yet.
ZhilkinSerg
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue where I could not create a woodchip floor, in an empty shallow pit.
I removed the precondition that required it to be empty, and now I can create woodchip floors just fine.
I looked at the definition for the empty precondition and it needs the square to be flat and have no furniture, which I'm unsure a shallow pit would count as.
I think the spirit of the empty precondition was that there should be no items but it also precluded shallow pits, perhaps there should be another check?
Also it seems quite possible this bug applies in other cases in this file, I haven't investigated yet.
Summary
Purpose of change
Describe the solution
Describe alternatives you've considered
Additional context