Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use point in Creature, monster, and player APIs #33115

Merged

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Refactoring in support of type safety and code clarity.

Describe the solution

Convert APIs in Creature, monster, and player taking x, y arguments into versions taking a point.

Refactor related code accordingly.

Additional context

Ultimately in support of #32017.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Aug 10, 2019
@ZhilkinSerg ZhilkinSerg merged commit 98aa32f into CleverRaven:master Aug 10, 2019
@jbytheway jbytheway deleted the point_in_creature_monster_player branch August 11, 2019 09:36
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* Point overloads for creature, monster, player APIs

* Porting to new APIs

* Implement new API

* Further refactoring pass

* Rewrite game::update_map

Refactor some variables into a point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants