Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire some inaccurate snippets #33014

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

A few ancient snippets reference lore elements that have been discarded over time.

Describe the solution

Remove the snippets.

Describe alternatives you've considered

We need a fuller audit since lore has shifted quite a bit over time, but before we cut too many we need new ones to replace them.

@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Lore Game lore, in-game communication. Also the Lore tab. labels Aug 8, 2019
@ZhilkinSerg ZhilkinSerg merged commit f717ab0 into master Aug 8, 2019
@kevingranade kevingranade deleted the kevingranade-snippet-purge branch August 12, 2019 23:20
@ghost ghost mentioned this pull request Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Lore Game lore, in-game communication. Also the Lore tab.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants