Invalidate all levels of map cache on map shift #32827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
commented
Aug 1, 2019
kevingranade
commented
Aug 1, 2019
ZhilkinSerg
added
<Bugfix>
misterprimus
pushed a commit
to misterprimus/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2019
* Invalidate all levels of map cache on map shift * typo fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #29175 again
Solution
The previous PR fixed one cause, but I finally stumbled across another cause of the problem, which occurs due to the map shifting code failing to invalidate the entire map cache.
Testing
Setup:
Locate a building with a roof you can climb onto, ideally one that is isolated.
Spawn a shocker inside the building, ideally shut in a closet or similar.
Climb onto the roof and walk above the area with the shocker.
Expected result:
Nothing happens
Actual Result:
Shocker shocks you through the roof, and you can sometimes see the shocker appear in the threat compass.
Follow-up:
Cross to the other side of the roof and then return.
The shocker no longer shocks you through the roof (because crossing the roof invalidated the appropriate caches).