-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Filter loot zone #32754
Custom Filter loot zone #32754
Conversation
Just applied this to my local branch and made a 'battery' zone. Not only does it work, but the item preview on the zone is a super-nice touch! Thank you! |
And now I'm reporting in with my first gotcha. I created uses a filter of |
Aaah, I see what's going on... |
Ahh right, forgot you can actualyl change the name of the item. |
Yeah, done, that seems to work, with the item itelf. |
Been doing some more testing locally, and this is working really great! For example, I have I'm 100% happy to consider this passing the bounty requirement once merged. :) |
I've been using this pretty heavily, and there's been only one gotcha that I've found. If there's a custom zone and a regular zone on the same tile, then it appears the regular zone gets ignored. For example, I have a custom zone for pinecones on top of my non-perishable foods. This results in non-perishables not getting sorted to that square any more. I've attached a save that demonstrates this. Turning off the 'dry food' and 'custom cellar' zones causes the food in the back of the vehicle to get sorted. With them still being enabled, the food just sits there. I wouldn't consider this to be a blocker, given that everything else seems to be working so well! |
Summary
SUMMARY: Features "Custom Filter loot zone"
Purpose of change
Fixes #25134
Describe the solution
Adds the string filter input from zone options to a string_item_filter when the loot sorting activity searches for the nearest correct tile to push the item to.
Describe alternatives you've considered
N/A
Additional context
This will need to be updated after #32730 is merged - it copies one of the funtions from there, for use in zone administration, and might not be in the same place afte rthat is merged, and also modifies the loot sorting activity, which is also modified in that PR, or vice versa if this is merged first