Port overmap API to points / tripoints #32645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert all overmap member functions taking x, y, z arguments to take points or tripoints instead. Port all calling code to use these new APIs. Add a couple of helpers to aid with this process: - om_to_omt_copy in coordinate_conversions.h - manhattan_dist in line.h - tripoint_above, tripoint_below, four_adjacent_offsets in point.h
KorGgenT
added
[C++]
jbytheway
added a commit
to jbytheway/Cataclysm-DDA
that referenced
this pull request
Jul 27, 2019
Refactor some of this code for better clarity. This was some refactoring that was supposed to be part of CleverRaven#32645 but I failed to push it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
To have more expressive APIs, and move towards better type safety and cleaner code.
Similar to #32300, but this time for
overmaprather thanovermapbuffer.Describe the solution
Convert all
overmapmember functions taking x, y, z arguments to takepointortripointarguments instead.Port all calling code to use these new APIs.
Add a couple of helpers to aid with this process:
om_to_omt_copyincoordinate_conversions.hmanhattan_distinline.htripoint_above,tripoint_below,four_adjacent_offsetsinpoint.hAdditional context
Working towards being able to meaningfully test #32017.