-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhauls and adds missing CBM descriptions #32335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fris0uman
reviewed
Jul 12, 2019
Fris0uman
reviewed
Jul 12, 2019
Fris0uman
reviewed
Jul 12, 2019
Fris0uman
reviewed
Jul 12, 2019
Fris0uman
reviewed
Jul 12, 2019
Fris0uman
reviewed
Jul 12, 2019
Fris0uman
reviewed
Jul 12, 2019
@Fris0uman Thanks for your review, I've changed the descriptions that you mentioned. |
Fris0uman
reviewed
Jul 12, 2019
No problem, thanks for your contribution ^^ 👍 |
ZhilkinSerg
added
[JSON]
Changes (can be) made in JSON
Bionics
CBM (Compact Bionic Modules)
Translation
I18n
labels
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Overhauls and adds missing CBM descriptions"
Purpose of change
Most CBM items have same description text as installed bionics - I adjusted them so that both have separate, more fitting descriptions.
My goal was to reduce the amount of flavor text in the descriptions of installed bionics, as these show up in the player info menu.
I believe that descriptions in the player info menu should be compact and informative, while the CBM item descriptions can be longer and more flavorful.
I also added missing descriptions, fixed some grammar issues and added missing details, like how the CQC bionic will prevent melee skill increase while active.
Describe the solution
An example of the descriptions I updated:
Power Storage Mk. II CBM (item)
A Compact Bionics Module developed at DoubleTech Industries as a replacement for the highly successful Power Storage CBM. Increases the user's power capacity by 250 units.
Power Storage Mk. II (installed bionic)
A Compact Bionics Module that increases your power capacity by 250 units.