Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhauls and adds missing CBM descriptions #32335

Merged
merged 3 commits into from
Jul 13, 2019

Conversation

81Denton
Copy link
Contributor

Summary

SUMMARY: Content "Overhauls and adds missing CBM descriptions"

Purpose of change

Most CBM items have same description text as installed bionics - I adjusted them so that both have separate, more fitting descriptions.
My goal was to reduce the amount of flavor text in the descriptions of installed bionics, as these show up in the player info menu.
I believe that descriptions in the player info menu should be compact and informative, while the CBM item descriptions can be longer and more flavorful.

I also added missing descriptions, fixed some grammar issues and added missing details, like how the CQC bionic will prevent melee skill increase while active.

Describe the solution

An example of the descriptions I updated:

Power Storage Mk. II CBM (item)
A Compact Bionics Module developed at DoubleTech Industries as a replacement for the highly successful Power Storage CBM. Increases the user's power capacity by 250 units.

Power Storage Mk. II (installed bionic)
A Compact Bionics Module that increases your power capacity by 250 units.

data/json/bionics.json Outdated Show resolved Hide resolved
data/json/bionics.json Outdated Show resolved Hide resolved
data/json/bionics.json Outdated Show resolved Hide resolved
data/json/bionics.json Outdated Show resolved Hide resolved
data/json/bionics.json Outdated Show resolved Hide resolved
data/json/bionics.json Outdated Show resolved Hide resolved
@81Denton
Copy link
Contributor Author

@Fris0uman Thanks for your review, I've changed the descriptions that you mentioned.

data/json/bionics.json Outdated Show resolved Hide resolved
@Fris0uman
Copy link
Contributor

No problem, thanks for your contribution ^^ 👍

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) Translation I18n labels Jul 12, 2019
@ZhilkinSerg ZhilkinSerg merged commit 49d4715 into CleverRaven:master Jul 13, 2019
@81Denton 81Denton deleted the bionic-descs branch July 14, 2019 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [JSON] Changes (can be) made in JSON Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants