-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magiclysm: Alchemy, Part 1-Potion tools and Stat Potion Brewing #32132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[JSON]
Changes (can be) made in JSON
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Items / Item Actions / Item Qualities
Items and how they work and interact
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods
Issues related to mods or modding
labels
Jul 4, 2019
ghost
changed the title
Magiclysm: Alchemy, Part 1 [WIP]
Magiclysm: Alchemy, Part 1-Potion tools and Stat Potion Brewing
Jul 5, 2019
KorGgenT
reviewed
Jul 5, 2019
KorGgenT
reviewed
Jul 5, 2019
ghost
commented
Jul 5, 2019
GitHub desktop won't push chance to hairball volume
ghost
commented
Jul 5, 2019
ghost
deleted the
Potions
branch
July 8, 2019 02:02
ghost
mentioned this pull request
Sep 23, 2019
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Items / Item Actions / Item Qualities
Items and how they work and interact
[JSON]
Changes (can be) made in JSON
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Magiclysm: First additions to alchemy"
Purpose of change
Potions spawning in the world imply there was a creation process to them.
Describe the solution
Adds two new tools utilizing the new tool qualities from #32051 for alchemy, a book with recipes in it for one tool and the four stat potions, a new harvest from large monsters and small furred mammals, and adjusts itemgroups to spawn in the new book. Additionally, the rune spells from #31687 are enabled to be learned upon taking a school.
Describe alternatives you've considered
Assuming the potions appeared fully made from nowhere and were collected in shops.