Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds skeletal shocker zombies #32115

Merged
merged 3 commits into from
Jul 9, 2019
Merged

Conversation

aoae23
Copy link
Contributor

@aoae23 aoae23 commented Jul 4, 2019

Summary

SUMMARY: Features "Adds skeletal shocker zombies"

Purpose of change

Kevin said they were viable so I tried my hand at it.

Describe the solution

They evolve from shockers. They trade mobility for skeletal style armour.

Describe alternatives you've considered

Not adding them.

Additional context

This is my first time messing with the monster code; please tell me what I'm doing wrong if anything.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Jul 4, 2019
@KorGgenT
Copy link
Member

KorGgenT commented Jul 5, 2019

I suggest you go with the new naming convention introduced in #32117 since "skeletal" isn't actually very accurate to the lore description of having a bunch of plating.

@@ -4556,7 +4556,8 @@
"default": "mon_null",
"monsters": [
{ "monster": "mon_zombie_nullfield", "freq": 550, "cost_multiplier": 0 },
{ "monster": "mon_zombie_brute_shocker", "freq": 300, "cost_multiplier": 2 }
{ "monster": "mon_zombie_brute_shocker", "freq": 300, "cost_multiplier": 2 },
{ "monster": "mon_zombie_skeletal_electric", "freq": 300, "cost_multiplier": 2 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either make this skeleton or the monster definition skeletal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Just fixed the monster definition.

@kevingranade kevingranade merged commit e4ca07d into CleverRaven:master Jul 9, 2019
@esotericist esotericist mentioned this pull request Jul 9, 2019
@aoae23 aoae23 deleted the patch-10 branch August 3, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants