Fix stamina expenditure when pulping #32043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code was improperly using a large and arbitrary "effectiveness" number as the stamina cost per strike, leading to character exhaustion.
ifreund
added
<Bugfix>
|
Jenkins rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: None
Purpose of change
Previous code was improperly using a large and arbitrary "effectiveness" number as the stamina cost per strike, leading to character exhaustion.
Describe the solution
Derive a separate effort value based on just the brute force component of pulping activity.
Bail out of the current turn of activity if stamina goes too low.
Reproduction case
Using a high strength character with a large bashing weapon and high survival skill, bash one or more corpses.
https://cdn.discordapp.com/attachments/365907426270117888/595366806768582715/unknown.png
Thanks to @derval for reporting and researching this.