IWYU 20190629 #31990
Merged
IWYU 20190629 #31990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
|
The Appveyor failure is a real problem. I'll have to look into that. |
Unclear why IWYU thinks this is needed. It isn't, and it causes problems on Visual Studio.
|
I think this is OK now. There's a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
It's been a while since the last IWYU run. Time to tidy up our headers again.
Describe the solution
Add two pragmas. Run IWYU & astyle (twice).
Additional context
Once pragma relates to the use of
extern templateconstructs that IWYU doesn't quite understand, I think. The other is required by something related tocolony. I didn't take the time to understand it fully.