UPS adapter mod crash fix #31800
Merged
UPS adapter mod crash fix #31800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary ammo_modifier
|
Apparently this is the only non-obsolete item using ammo_modifier. We need to just rip out the code using ammo_modifier if it's completely broken and unused. |
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Crash when inspecting a tool with UPS conversion mod attached"Purpose of change
Fixes #31688 - UPS conversion mod crash
Fixes #31633 - Examining UPS modded tool causes error
Describe the solution
Removed unnecessary ammo_modifier field in UPS conversion mod definition, as since #31766 tool is not using internal ammo after attaching a mod.
Describe alternatives you've considered
I don't know.
Additional context
None