Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minimum required charges to mp3 player, noise emitter and vibrator #31431

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Added minimum required charges to mp3 player, noise emitter and vibrator #31431

merged 1 commit into from
Jun 14, 2019

Conversation

Night-Pryanik
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Added minimum required charges to mp3 player, noise emitter and vibrator."

Purpose of change

Closes #28601 - Tools usable without charges via Battery Compartment toolmod.

Describe the solution

Added charges_per_use for mp3 player, noise emitter and vibrator. Seems like a simple oversight.

@Night-Pryanik Night-Pryanik added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) labels Jun 14, 2019
@ZhilkinSerg ZhilkinSerg merged commit ab77065 into CleverRaven:master Jun 14, 2019
@Night-Pryanik Night-Pryanik deleted the tools-require-charges-to-use branch June 15, 2019 06:39
@jbytheway
Copy link
Contributor

Can we have something in the item finalization code that checks for this field being missing when it should be present?

@ZhilkinSerg
Copy link
Contributor

Good candidate for Item_factory::check_definitions()

@tinukedaya
Copy link
Contributor

btw: Vibrators were supposed to work without charges. They were made that way with #21984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tools useable without charges via Battery Compartment toolmod
4 participants